Add auto-merge for nodenv-bot PRs
#738
Comments
|
I can ask junior developers to create PR for that if you want |
|
PR - #740 |
|
The main concern I have with auto-merging is that node-build has a high degree of power on user's machines. Each build definition is essentially a bash script being executed. Before we have any automatic merging, we should have additional safeguards in place (probably extra CI suites), that ensure each build definition is only invoking our functions and is only fetching from expected sites (both could be checked against allowlists). If we get this additional CI check in place, such that it is optional on PRs (shouldn't prevent manual PR merges), yet required for auto-merging, then I would be more inclined to land an automerge setup. |
|
PR - #756 |
kachick
added a commit
to kachick/renovate-config-asdf
that referenced
this issue
Aug 10, 2023
nodenv/node-build#738 nodenv/node-build#823 is not yet merged #1076 will be passed since this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On new Node.js version release
nodenv-botbot sends PR like #736It could take a few days to merge it.
It will be very nice to add CI script to merge green PRs from
nodenv-botautomatically.The text was updated successfully, but these errors were encountered: