Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prefix moving #237

Open
jasonkarns opened this issue Feb 14, 2017 · 0 comments · May be fixed by #284
Open

Support prefix moving #237

jasonkarns opened this issue Feb 14, 2017 · 0 comments · May be fixed by #284

Comments

@jasonkarns
Copy link
Member

jasonkarns commented Feb 14, 2017

We would like to have definitions like latest, nightly, lts, current, etc which pull down the "latest" respective version. Ideally, we would like the installed version to be named precisely per the version number as having an installed version named latest is hardly useful after a few days.

  • perhaps attempt to mv the version in after_install_package hook, accounting for PREFIX_PATH (see Revert "After install, rename nightly to the actual version string" #236 )
  • perhaps attempt to modify the PREFIX_PATH as part of the definitions "main" run, rather than in hooks?
  • perhaps we need to expose a hook in node-build that a definition can invoke to force/override the installed package name?

Questions to resolve:

  1. What to do when a given architecture is not included in the specified "latest" build? Should it build latest from source? Or get a slightly older version that does have a binary build? This would require checking platform in the build definition itself.
  2. What to do when the "latest" is already installed? The pre-install check that node-build performs is based on the build definition filename. This will be insufficient if the version name isn't known until the definition is run.

closes #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@jasonkarns and others