How to disable the use of drop-down selection boxes under editor permissions?

[c2006878]

I found that under editor permissions, users can select from the table drop-down box. But under viewer permissions, users cannot. I now want to disable the drop-down box selection function under editor permissions as well. Does anyone know which file I need to modify?

[dosubot[bot]]

To disable the drop-down selection boxes for users with editor permissions, you can use the "UI Access Control" (UI ACL) feature in NocoDB. This feature allows you to enable or disable access to specific tables for different roles, which can indirectly control the visibility and accessibility of UI components like drop-down selection boxes.

Here are the steps to configure UI ACL:

1. Open the Data Sources tab in the Base Settings homepage.
2. Select the data source you wish to configure UI ACL for.
3. Select the UI ACL tab.
4. You will see a list of views and tables available in the data source as rows and roles available as columns. Toggle the checkboxes to enable/disable access to tables for specific roles.
5. Click on the Save button to save the changes.

This will allow you to control the access to drop-down selection boxes based on user roles, including disabling them for editors.

For more detailed customization, you might need to modify the code in the UIAcl.vue component, which manages the visibility of tables for different user roles. Here is a relevant code snippet:

const roles = ref<string[]>(['editor', 'commenter', 'viewer'])

const allSelected = computed(() => {
  return roles.value.reduce((acc, role) => {
    return {
      ...acc,
      [role]: tables.value.filter((t) => t.disabled[role]).length === 0,
    }
  }, {} as Record<Role, boolean>)
})

const toggleSelectAll = (role: Role) => {
  const newValue = !allSelected.value[role]

  tables.value.forEach((t) => {
    t.disabled[role] = newValue
    t.edited = true
  })
}

const onRoleCheck = (record: any, role: Role) => {
  record.disabled[role] = !record.disabled[role]
  record.edited = true
}

This code snippet shows how to manage the visibility of tables based on user roles, which can be adapted to disable drop-down selection boxes for editors ^[1][2].

To continue talking to Dosu, mention @dosu.

[c2006878]

function makeEditable(row: Row, col: ColumnType) {

if ([UITypes.SingleSelect].includes(col.uidt as UITypes)) {
return
}

return (editEnabled.value = true)
}

What I mean is that the above code is still editable when the type is SingleSelect. But if the type is changed to SingleLineText, it is not editable. Where else should I modify the code?

[dosubot[bot]]

To ensure that the makeEditable function disables editing for SingleSelect types but allows editing for SingleLineText types, you need to modify the conditional checks within the function. Here is the corrected version of the function:

function makeEditable(row: Row, col: ColumnType) {
  if (!hasEditPermission.value || editEnabled.value || isView || readOnly.value || isSystemColumn(col)) {
    return;
  }

  if (!isPkAvail.value && !row.rowMeta.new) {
    // Update not allowed for table which doesn't have primary Key
    message.info(t('msg.info.updateNotAllowedWithoutPK'));
    return;
  }

  if (col.ai) {
    // Auto Increment field is not editable
    message.info(t('msg.info.autoIncFieldNotEditable'));
    return;
  }

  if (col.pk && !row.rowMeta.new) {
    // Editing primary key not supported
    message.info(t('msg.info.editingPKnotSupported'));
    return;
  }

  if (col.uidt === UITypes.SingleSelect) {
    // Disable editing for SingleSelect types
    return;
  }

  if (col.uidt === UITypes.SingleLineText) {
    // Allow editing for SingleLineText types
    return (editEnabled.value = true);
  }

  // Default behavior for other types
  return (editEnabled.value = true);
}

In this code, the makeEditable function checks the col.uidt property. If the column type is SingleSelect, it returns without enabling editing. If the column type is SingleLineText, it sets editEnabled.value to true to allow editing. For other column types, it defaults to allowing editing ^[1][2].

To continue talking to Dosu, mention @dosu.

[c2006878]

No, the SingleSelect is still editable. Has anyone found this problem?