Replies: 13 comments 9 replies
-
|
Playwrite describes their electron support as "Playwright has experimental support for Electron automation." Does it make sense for this plugin to adopt libraries that are self-described as experimental? |
Beta Was this translation helpful? Give feedback.
-
|
While I generally avoid using experimental features, I don't have any choice here. Spectron is becoming deprecated (electron-userland/spectron#1045) and doesn't support the latest Electron version anymore. It also has some unfortunate drawbacks (like requiring nodeIntegration and the remote module) that Playwright doesn't have. As far as I know there aren't any other alternatives, so Playwright is the only option. Even though it's experimental, it seems to work well. If a well-maintained fork of Spectron (or another alternative) pops up that works better than Playwright, I'll look into switching to that. |
Beta Was this translation helpful? Give feedback.
-
|
Ah, Playwrite makes much more sense in that context! Thanks for explaining and thanks for your work on this library |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your work on this library! I found that in the V3 Alpha version，"electron-builder" version still is : "^22.2.0", I think is too old ,and exist some bug, can you update "electron-builder" to the latest version？Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
That's the latest major version of electron-builder, so the latest version will be installed when the plugin is added. |
Beta Was this translation helpful? Give feedback.
-
|
Could you set I am not sure what Playwright is doing, but I don't think we need to download any browsers. As it should support already installed browsers, see https://playwright.dev/docs/browsers. Also metioned in electron-userland/spectron#1045 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
I use |
Beta Was this translation helpful? Give feedback.
-
|
I also opened #1650. As that is required to get mocha tests working. |
Beta Was this translation helpful? Give feedback.
-
|
I have made some efforts to get the tests working. Though this is very much WIP, you can find my changes at https://github.com/MatthijsBurgh/vue-cli-plugin-electron-builder/tree/v3_update |
Beta Was this translation helpful? Give feedback.
-
|
Hi, just to share my personnal experience migrating from SimulatedGREG/electron-vue Thanks a lot for your work. |
Beta Was this translation helpful? Give feedback.
-
|
I think we should actually go for WebDriver IO as testing interface. It is also suggested in the electron documentation. The Playwright API is very limited. One very big reason to go for WebDriver IO is that you can set the port to use. Which was also in the spectron API. This is needed for the tests in this package. As these run in parallel with different ports. Using playwright here, would require all tests to run in serie. I have no idea, how easy that is, but it would slow down the testing significant. As we also test the test function (testWithSpectron/testWithPlayWright), supporting Playwright to be used by the end-users of this project is also a big challenge. So I suggest to fully go for WebDriverIO. In the electron documentation, they suggest both WebDriverIO as Selenium for the WebDriver interface. I don't have enough knowledge to choose one over the other. So please share your opinion/knowledge on that one. |
Beta Was this translation helpful? Give feedback.
-
|
I've been mostly out of the JS space for a while so I don't really have much opinion here, but it seems that playwright uses IPC to control the electron app instead of a network port, so it shouldn't have any parallelism issues. In fact, it runs test files in parallel by default, but I'm not sure if that applies to Electron. I also like that it has it's own test runner, so we can separate the VueJS unit testing and the Electron E2E testing. It really makes sense to have a different testing environment for Vue and Electron testing as Vue should run in a browser-like environment whereas Electron runs in a Node-like one. It also means we only have to support one test framework instead of Mocha and Jest. I'm not sure what the API limitations are, that could be a significant issue. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I missed that part. That should keep Playwright an option. I will try to look into the API of playwright, WebDriverIO and Selenium to which provides the best API for the end-user.
Can you please elaborate on this one. |
Beta Was this translation helpful? Give feedback.
-
|
Playwright has its own test framework which we could use instead of Jest/Mocha. I don't see much of a need to support Jest/Mocha when we can use the included test framework (unless it has some serious issue). Therefore, we could just support the Playwright test runner and not have to bother with jest/mocha. |
Beta Was this translation helpful? Give feedback.
-
|
Is the repository is still under maintenance? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, it is under maintenance. Just very at very inconsistent times. |
Beta Was this translation helpful? Give feedback.
-
|
Eager to see v3 released ! ❣️ |
Beta Was this translation helpful? Give feedback.
-
|
Help needed, Issues with upgrading |
Beta Was this translation helpful? Give feedback.
-
|
I want to start a browser by clicking on the page and control it through playwright, similar to this！！ But I'm in background The process builder reported these errors when it was introduced into JS, How to use playwright in Vue cli plugin electron builder?? thank you very much |
Beta Was this translation helpful? Give feedback.
-
|
try to set in const { defineConfig } = require('@vue/cli-service')
module.exports = defineConfig({
pluginOptions: {
electronBuilder: {
externals: ['playwright'],
},
},
}) |
Beta Was this translation helpful? Give feedback.
-
|
OK, the problem is solved. Thank you very much |
Beta Was this translation helpful? Give feedback.
-
|
Hey there ! First of all, thanks for your work. |
Beta Was this translation helpful? Give feedback.
-
I'm happy to announce the first alpha of v3 is here! This release mainly updates all dependencies and cleans up some legacy code. There are no docs yet and this hasn't been tested thoroughly so be careful when using this in production. Please give me feedback and issue reports so I can promote this to stable ASAP.
Key Features/Fixes
Upgrading/Breaking Changes
background.jsshouldn't require any changes, but you can remove theenableRemoteModulesetting for Spectron if it's theretestWithSpectronhas been renamed totestWithPlaywright, and doesn't take the Spectron import as an arg. The returnedappis now a Playwright ElectronApplication instead of a Spectron instance, andstopServehas been renamed tostop. You don't need to install Playwright, it's a dependency of this plugin.TODO
This discussion was created from the release V3 Alpha!.
Beta Was this translation helpful? Give feedback.
All reactions