Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a working webview again #246

Closed
Atemu opened this issue Oct 26, 2024 · 2 comments · Fixed by #268
Closed

Provide a working webview again #246

Atemu opened this issue Oct 26, 2024 · 2 comments · Fixed by #268

Comments

@Atemu
Copy link
Contributor

Atemu commented Oct 26, 2024

Robotnix currently cannot provide a working webview because nobody has touched anything Chromium related since Daniel stopped working on it.

We should provide some modern webview by default such as Mulch, cromite or something like that. Pre-built would be fine for now until someone wants to take on from-source builds again.
@Atemu
Copy link
Contributor Author

Atemu commented Oct 26, 2024

Researching this further, I've gathered two facts:

  • cromite cannot be used as a webview
  • vanadium webview cannot be used on non-GrapheneOS

That leaves us with Mulch which is what divestOS uses. Apparently it uses GMS deps though? :/

@Atemu
Copy link
Contributor Author

Atemu commented Oct 26, 2024

Adding the webview requires adding an overlay with the webview provider specified:

https://gitlab.com/divested-mobile/divestos-build/-/blob/5934339248918537bff19cfc75705d04e528f37b/Patches/Common/config_webview_packages.xml

We have infra for this in robotnix already in the webview module, we seemingly just need to wire up the APK?

@Atemu Atemu mentioned this issue Nov 24, 2024
Open
@Atemu Atemu mentioned this issue Dec 28, 2024
Merged
Atemu added a commit to Atemu/robotnix that referenced this issue Dec 28, 2024
@Atemu
lineageos: allow prebuilt webview
430b818 
We don't have a working webview which would mean you'd need to install one
yourself at runtime. LOS ships a prebuilt webview, let's simply use that.

Fixes nix-community#246
@Atemu Atemu closed this as completed in #268 Jan 6, 2025
@Atemu Atemu closed this as completed in c8cfca8 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lineageos: allow prebuilt webview Atemu/robotnix
1 participant
@Atemu