-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/telescope: support non-builtin keymaps #1544
plugins/telescope: support non-builtin keymaps #1544
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<cmd>
mappings are not echod, so thekeymapsSilent
option now has no effect and could be deprecated.
Let's do that in this PR then.
I think there's a design decision to make here. Using using the
However
It's also unclear whether all third-party extensions will expose their picker functions via the That said, this is already more powerful than the current approach, since the current telescope keymap wrapper doesn't allow passing any option arguments to the picker function anyway. Nor does it allow using third-party (extension) pickers. If we decide we don't like the We could also augment either the old or new system by allowing |
cbb2236
to
d2b47ad
Compare
@GaetanLepage could you re-review when you have chance? |
Use the `:Telescope` command instead of relying directly on `require("telescope.builtin")`.
d2b47ad
to
56d39f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! LGTM.
Use the
:Telescope
command instead of relying directly onrequire("telescope.builtin")
.To quote upstream docs:
Fixes #1493