Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay support? #1

Open
LEXUGE opened this issue Aug 25, 2020 · 9 comments
Open

Overlay support? #1

LEXUGE opened this issue Aug 25, 2020 · 9 comments

Comments

@LEXUGE
Copy link

LEXUGE commented Aug 25, 2020

Nice work done!
I wonder if we can have overlay support? This can make things much easier to deploy (and cleaner).

Thanks again for your impressive work.

@colemickens
Copy link
Member

Can you explain why it makes things easier or cleaner? From thinking it over in my head, and having used nixpkgs-wayland as an overlay, their usage is fairly similar. And to me at least, pulling one package from another package set is conceptually simpler than learning how overlays compose.

That having been said, it would be relatively easy to add...

@colemickens
Copy link
Member

I guess the overlay would make more sense if I added the rest of the firefox bin outputs.

@LEXUGE
Copy link
Author

LEXUGE commented Aug 26, 2020

Because I am in favor to not use specialargs to pass in inputs which would be required without overlay. Also, as you said, it is making sense with multiple bin presented.

On top of that, overlay is also an choice for other people as well,

@colemickens
Copy link
Member

I see. I still configure my overlay down inside my system config, but I see what you're saying if you apply the overlay at the top.

Makes sense, I'd take a PR or I can get to it sometime. :)

@alienzj
Copy link

alienzj commented Sep 15, 2022

Now can we use it ?

@colemickens
Copy link
Member

I am going to leave this open just because I don't think you can actually overlay this yourself since you'd only have access to a system-specific derivation. I do think there's a tiny slight different usage that can be unlocked offering up the overlay and it matches what I do in nixpkgs-wayland anyway.

Still, unfortunately, not a priority. And as I indicated in the other issue @alienzj, this shouldn't block you.

@alienzj
Copy link

alienzj commented Sep 19, 2022

@colemickens Thanks. Let me try the method you indicated in the other issue.

@BhasherBEL
Copy link

Have you been able to use this with home manager, without overlays? Afaik inputs can't be passed as easily to home manager, while it's trivial to share the pkgs.

@colemickens
Copy link
Member

I use home-manager as a nixos module, and can use inputs. I don't use an overlay though, I directly access the package from this flake's outputs.

It looks like home-manager has a extraSpecialArgs option that you can use to propagate inputs to home-manager modules, similar to how folks do with specialArgs and nixos modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants