Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine flake-parts interface (translators) #424

Open
DavHau opened this issue Dec 14, 2022 · 1 comment
Open

refine flake-parts interface (translators) #424

DavHau opened this issue Dec 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@DavHau
Copy link
Member

DavHau commented Dec 14, 2022

Currently the translator field accepts any string, and also there is no documentation for the translator options which differ between the individual translators.

I think in order to have nice documentation for the translators, they each need to have their own options like:

{
  perSystem.dream2nix.inputs.<name>.projects.<name>.translator = "package-lock";
  perSystem.dream2nix.inputs.<name>.projects.<name>.translatorArgs.package-lock.nodejs = 18;
}

While touching the translators, we should probably also:

  • move them to /src/module to follow the same schema like our other modules. Currently translators still reside in /src/subsystems/{subsystem}/translators
  • after doing the same with builders and discoverers, this will allow us to get rid of our legacy module loading mechanism defined in src/modules/subsystem-loading.nix
@DavHau DavHau added the enhancement New feature or request label Dec 14, 2022
@DavHau
Copy link
Member Author

DavHau commented Dec 14, 2022

I started implementing this via #425. So far I only moved the package-lock translator as an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant