Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Firefox v52 supported? #52

Open
jrnail23 opened this issue Aug 30, 2018 · 6 comments
Open

Question: Firefox v52 supported? #52

jrnail23 opened this issue Aug 30, 2018 · 6 comments
Labels

Comments

@jrnail23
Copy link

Is react-perf-devtool supposed to work with Firefox v52?
Since I couldn't get the browser extensions working, I'm using the custom callback to write metrics to my console. While it works fine in Chrome, nothing happens in Firefox v52 (I'm trying to investigate performance issues specific to FFv52). It looks like my callback just isn't getting invoked.

@nitin42
Copy link
Owner

nitin42 commented Aug 30, 2018

I think I uploaded the Firefox build too last time but it's not being actively maintained since I am the only one who is taking care of code, docs, support and other maintaining stuff 😅

@jrnail23
Copy link
Author

@nitin42, I totally understand, and thanks for being so responsive! To be clear, my specific issue here isn't with the browser extensions, but with react-perf-devtool's observer callback -- the callback should work without the extension, right?

@nitin42
Copy link
Owner

nitin42 commented Aug 30, 2018

It should work!

Look at the screenshot below, you should be able to see the console logging the object _REACT_PERF_DEVTOOL_GLOBAL_STORE

screenshot 2018-08-30 at 11 34 41 pm

I am using Firefox quantum (latest release)

Make sure you are using the current stable [email protected]

@jrnail23
Copy link
Author

jrnail23 commented Aug 30, 2018

in Firefox v52, __REACT_PERF_DEVTOOL_GLOBAL_STORE__ is undefined (but in Chrome, of course, it's fine).
I'm guessing maybe this older version of Firefox just isn't compatible with the performance API being used -- again, I'm intentionally on an older version to troubleshoot specific customer problems, so this isn't terribly surprising.

Anyway, you can probably just go ahead and close this issue. Keep up the good work -- I'm looking forward to seeing what this tool can do!

@nitin42
Copy link
Owner

nitin42 commented Aug 30, 2018

Thanks! Yes, it seems like that version of Firefox doesn't support PerformanceObserver. Let me check if we can use a polyfill here, so I'll keep this issue open!

@flxwu flxwu added the on hold label Sep 11, 2018
@flxwu
Copy link
Collaborator

flxwu commented Sep 11, 2018

Set to on hold, if anyone finds a polyfill for window.PerformanceObserver (or when polyfill.io adds it) we can polyfill it to add support for older browser versions! For now, I'll add a notice in the README for Browser Compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants