Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexView crashes if startAddress is 0 + a few requests #1

Open
EParisot opened this issue Jan 20, 2021 · 4 comments
Open

hexView crashes if startAddress is 0 + a few requests #1

EParisot opened this issue Jan 20, 2021 · 4 comments

Comments

@EParisot
Copy link

EParisot commented Jan 20, 2021

Hi and thank you for this great package !

I had a small trouble to use hexView from a Uint8List and had to cast it to a List explicitelly... weird...
hexView(5, new List.from(data));

But anyway it works as intended !

I would like to know if you planned to include an ASCII representation like in wireshark or hexdump ??
image example

EDIT: nevermind my request, I ended up editing your package myself... Do you accept PRs ?

@EParisot EParisot changed the title A few requests hexView crashes if startAddress is 0 + a few requests Jan 20, 2021
@EParisot
Copy link
Author

EParisot commented Jan 20, 2021

Wait, in fact, I don't want a "startAddress" at 5 but from 0, but it crash if I do so... So I think the problem is that the lib doesn't support 0 as a startaddress or am I missing something ?

the error if I use a ZERO as startAddress, from the example :
[ERROR:flutter/lib/ui/ui_dart_state.cc(184)] Unhandled Exception: type 'SubListIterable<int>' is not a subtype of type 'List<int>'

EDIT : I also fixed this in my version, you simply need to add an else case in the suffix and prefix functions, and cast data to List ( data.toList() ) before return...

@tejainece
Copy link
Collaborator

Can you send a pull request?

@tejainece
Copy link
Collaborator

please create a seperate issue for hexdump viewer

@EParisot
Copy link
Author

EParisot commented Jan 21, 2021

Well I fixed it so my intention was to PR and to close this issue ...

Done anyway !

PR done btw ... have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants