Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow dashes in package names via package_scanner #1698

Open
dom96 opened this issue Nov 5, 2020 · 3 comments
Open

disallow dashes in package names via package_scanner #1698

dom96 opened this issue Nov 5, 2020 · 3 comments
Assignees
@Yepoleb

Comments

@dom96
Copy link
Contributor

dom96 commented Nov 5, 2020

No description provided.

dom96 referenced this issue Nov 5, 2020
@dom96
Fixes dash in ternary-tree. Refs #1683
1f0103a
@Yepoleb Yepoleb self-assigned this Mar 2, 2023
@ringabout ringabout moved this from Todo to In Progress in Contribution-friendly issues Mar 3, 2023
@Yepoleb
Copy link
Collaborator

Yepoleb commented Mar 3, 2023

What should be done with the detected packages? Should I rename them with an underscore and add an alias?

@ringabout
Copy link
Member

ringabout commented Mar 4, 2023 •
edited
Loading

Yeah, rename or disable warnings for them. Whatever is easier to do should be the solution.

@Yepoleb
Copy link
Collaborator

Yepoleb commented Mar 8, 2023

We decided this needs to be discussed in an RFC because it only makes sense if we enforce package names to match module names, which is a much bigger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yepoleb Yepoleb

Labels
None yet
Projects
Contribution-friendly issues
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dom96 @Yepoleb @ringabout