-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Workaround relative links #15
Comments
Would be really nice, but this is so messy code-wise that I personally don't want to go down that road. You'd also have to consider images which are in private repos, which is already tricky (see #13 ) and would (at least for Bitbucket) not even be possible at all as the plugin can't create the Also, when requesting the raw markdown from each provider, you'd have to parse the entire raw markdown string and pick out markdown image tags ( If you have a look into the code and you think it's doable in a reasonable fashion I'm happy to discuss or review a PR. Maybe there's even a workaround for the authentication issue. |
Hi nilsnolde, First, I get the content of the image and convert it to base64 encoding; Installation steps of parsedown(Put the decompressed file into documents-from-git/php_tool/)
class-base-loader.php
class-gitlab-loader.php
Best Regards |
Thanks @MIKEXU2017. I didn't really look at the code yet, as it's easier to do that in a PR setting. Would you be interested in contributing a robust version of this functionality? Few things that'd come to mind for a PR:
|
@nilsnolde Sorry, I have no experience in using git submodules, I only modified gitlab because I am using gitlab. I don't know if other things (such as github) will have problems. By the way, the token of the edit_image_link function is obtained from the get_document function, so as long as the token is given, there is no problem in obtaining the image of the private repo. In fact, I just provide some suggestions, then tell you the changes I made, and finally improve your PR yourself because I want to be lazy. (* ^ _ ^ *) The file compression package (containing two modified files) has been placed in the previous comment. Best Regards |
Ok. No thanks, I have no interest in this functionality. However, I'd be happy to review PRs going in that direction for some future dev who's not as lazy;) |
It would be great if you could process relative links like
[a link](./INSTALL.md)
and images to point to the original resource. Specially for images this is really important.Danke!
The text was updated successfully, but these errors were encountered: