-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/havok material #69
base: develop
Are you sure you want to change the base?
Conversation
When trying to export a .nif from Oblivion in the Blender nif export addon, execution of the mopper fails because of this line. Line 168 in 7f4404d
Removing ".material" there allows the mopper to run. Together with the other ".material" fixes in this PR (discussed in niftools/blender_niftools_addon#453), the export process becomes at least able to finish without errors. The resultant .nif still had problems the last I checked (before niftools/blender_niftools_addon@e8ede44). Oblivion would crash when loading the .nif file, but I found that opening it in NifSkope and saving it with auto-sanitize on would fix this and allow it to at least load in Oblivion without crashing. (It still had a misaligned collision mesh, and probably other issues as well) Any chance of this PR being merged sometime soon? I had thought about sending in a PR with the .material fixes, but then I saw that they were already in this PR, except for the Edit: I just tried with niftools/blender_niftools_addon@e8ede44 applied together with the .material removals, but the exported .nif still has the same problems (crashing on load, misaligned collision). |
We found that there was several other issues between the previous release version and this version @HENDRIX-ZT2 & @Candoran2 are working on integrating a different library which would have more modern nif.xml support which avoids the above issues. |
@niftools/pyffi-reviewer
Overview
[Overview of content of the pull request]
Fix issue with Havok Material for current version of nif.xml
Fixes Known Issues
[Ordered list of issues fixed by this PR]
Detailed Description
[List of functional updates]
Revert
.material.material
tomaterial
due to using older version of nif.xmlDocumentation
[Overview of updates to documentation]
N/A
Testing
[Overview of testing required to ensure functionality is correctly implemented]
Manual
[Order steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]