Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating (dev) dependencies and tests. #65

Open
nielsgl opened this issue Feb 11, 2019 · 4 comments
Open

Updating (dev) dependencies and tests. #65

nielsgl opened this issue Feb 11, 2019 · 4 comments
Labels
awaiting-review enhancement help wanted

Comments

@nielsgl
Copy link
Owner

nielsgl commented Feb 11, 2019

The (dev)dependencies are very outdated and tests don't cover a lot of the recent added functionality. If anyone is interested in helping out please let me know 🏆
@ksfreitas
Copy link
Contributor

I will take a look, but may I take a some time to do this...
work :(

@madlemur
Copy link

Just submitted a pull request that, among other things, updates the dependencies and adds some functional tests... :)

@nielsgl
Copy link
Owner Author

nielsgl commented Feb 27, 2019

Awesome @madlemur I'll set some time apart tomorrow to take my time and review it 💥

@nielsgl
Copy link
Owner Author

nielsgl commented Mar 2, 2019

Thanks @madlemur merged it and released as 2.5.0 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-review enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madlemur @nielsgl @ksfreitas