Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subseq? not swap subseq? #11

Open
mrjbq7 opened this issue Jan 21, 2017 · 4 comments
Open

subseq? not swap subseq? #11

mrjbq7 opened this issue Jan 21, 2017 · 4 comments

Comments

@mrjbq7
Copy link

mrjbq7 commented Jan 21, 2017

Hi,

I pushed a (breaking) change to the development branch of Factor that swaps the arguments for start, start*, and subseq?. You have a couple swap subseq? that should just be subseq? now.

It's more natural, but it does create a backwards compatibility problem in a relatively common word.

Thanks,

@nicolas-p
Copy link
Owner

I welcome this change. And apparently I only had two occurrences of subseq? in my code so it was easy to change.

@mrjbq7
Copy link
Author

mrjbq7 commented Jan 21, 2017

Looks like I might revert and delay this change until after we release 0.98 which should be soon.

@nicolas-p
Copy link
Owner

It's a good thing that my commit didn't leave my computer!

@mrjbq7
Copy link
Author

mrjbq7 commented Jan 21, 2017

Hah! Sorry for the churn. I have a list of things to cleanup like subseq?, but a few people pointed out that 0.98 would be a much better thing to get released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants