Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Unexpectedly Closes on Item Selection Despite closeOnSelect Being Set to False #2290

Open
XkoderFX opened this issue Jan 28, 2024 · 1 comment · May be fixed by #2598
Open

Dropdown Unexpectedly Closes on Item Selection Despite closeOnSelect Being Set to False #2290

XkoderFX opened this issue Jan 28, 2024 · 1 comment · May be fixed by #2598
Labels
🐛 Type: Bug Something isn't working

Comments

@XkoderFX
Copy link

XkoderFX commented Jan 28, 2024 •
edited

NextUI Version

2.2.9

Describe the bug

I'm experiencing an unexpected behavior with the closeOnSelect property in a DropdownItem component. Contrary to the expected functionality, the Dropdown closes upon the item selection, even though closeOnSelect is explicitly set to false.

Your Example Website or App

https://codesandbox.io/p/devbox/dazzling-williams-x2q5sh

Steps to Reproduce the Bug or Issue

  1. create a DropdownItem component with multiple selectable items.
  2. Explicitly set the closeOnSelect property to false for a DropdownItem.
  3. Notice that the Dropdown menu closes upon the selection, contrary to the expected behavior.

Expected behavior

When closeOnSelect is set to false, selecting the item with closeOnSelect should not close the Dropdown menu.

Screenshots or Videos

No response

Operating System Version

macOS (13.6.3)

Browser

Edge
@XkoderFX XkoderFX added the 🐛 Type: Bug Something isn't working label Jan 28, 2024
@kuri-sun
Copy link
Member

Hi @XkoderFX! Thanks for reporting the issue! I will take a look at this and fix it accordingly! Thank you 😄

gtoxlili added a commit to gtoxlili/nextui that referenced this issue Mar 27, 2024
@gtoxlili
fix(dropdown): fix dropdown menu unexpected close when closeOnSelect …
8e21dc2 
…is false (nextui-org#2290)
@gtoxlili gtoxlili linked a pull request Mar 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown): respect closeOnSelect prop on DropdownItem(#2290) gtoxlili/nextui
2 participants
@kuri-sun @XkoderFX