Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to IRegistrationContext::registerAlternativeLogin #762

Open
julien-nc opened this issue Jan 16, 2024 · 1 comment
Open

Switch to IRegistrationContext::registerAlternativeLogin #762

julien-nc opened this issue Jan 16, 2024 · 1 comment
Assignees

Comments

@julien-nc
Copy link
Member

As mentioned in https://github.com/nextcloud/user_oidc/blob/4db5bc0/lib/AppInfo/Application.php#L113
OC_App::registerLogIn is deprecated since NC 20.

The new way to register a login method (leading to an extra button in the login form) is to call IRegistrationContext::registerAlternativeLogin in the app's Application::register.

Problems:

  • Getting the db connection (\OC::$server->get(ProviderMapper::class); might work)
  • We can only register classes with the new system. How are we going to register the same class multiple times but make it point to different oidc providers?

@juliushaertl Not very urgent but at some point the deprecated OC_App::registerLogIn will be gone.

@julien-nc julien-nc self-assigned this Jan 16, 2024
@juliushaertl
Copy link
Member

We can only register classes with the new system. How are we going to register the same class multiple times but make it point to different oidc providers?

Yeah that one is tricky, I don't see a good way of migrating without adjustments to the server API for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants