propfind still works with 207

[tobiasKaminsky]

• have an user that needs to accept ToS
• do a propfind
• see that 207 is returned
• download then fails with 404

[tobiasKaminsky]

Ref #959

[tobiasKaminsky]

Download fails wit:

{"reqId":"PnupcpNfe5VV4cbPcvrd","level":0,"time":"2024-10-10T12:58:54+00:00","remoteAddr":"172.18.0.1","user":"test","app":"webdav","method":"GET","url":"/remote.php/dav/files/test/welcome.txt","message":"Exception thrown: Sabre\\DAV\\Exception\\NotFound","userAgent":"curl/8.10.1","version":"30.0.1.0","exception":{"Exception":"Sabre\\DAV\\Exception\\NotFound","Message":"","Code":0,"Trace":[{"file":"/var/www/html/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":85,"function":"get","class":"OCA\\DAV\\Connector\\Sabre\\File","type":"->"},{"file":"/var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpGet","class":"Sabre\\DAV\\CorePlugin","type":"->"},{"file":"/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/html/apps/dav/lib/Connector/Sabre/Server.php","line":43,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/html/apps/dav/lib/Server.php","line":370,"function":"start","class":"OCA\\DAV\\Connector\\Sabre\\Server","type":"->"},{"file":"/var/www/html/apps/dav/appinfo/v2/remote.php","line":19,"function":"exec","class":"OCA\\DAV\\Server","type":"->"},{"file":"/var/www/html/remote.php","line":146,"args":["/var/www/html/apps/dav/appinfo/v2/remote.php"],"function":"require_once"}],"File":"/var/www/html/apps/dav/lib/Connector/Sabre/File.php","Line":454,"message":"","exception":{},"CustomMessage":"Exception thrown: Sabre\\DAV\\Exception\\NotFound"}}

[tobiasKaminsky]

My idea:

• user needs to sign ToS
• all webdav/ocs commands are blocked with 401
  • error class can be TermsNotSignedException
  • send link to ToS

[tobiasKaminsky]

ExpiredTokenException

[max-nextcloud]

When using the browser terms of service will lead to 403 responses to PROPFIND because of https://github.com/nextcloud/terms_of_service/blob/master/lib/Dav/CheckPlugin.php (most likely). So interesting this does not work from the ios app. I suspect that's due to the different auth mechanism.

[max-nextcloud]

Talked with @juliusknorr today. Julius found this gem: #510