Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Contacts activity (group creation, federation invitations, ...) #3794

Open
mahibi opened this issue Apr 3, 2024 · 1 comment
Open
Assignees
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🌐 federation Support for federated conversations

Comments

@mahibi
Copy link
Collaborator

mahibi commented Apr 3, 2024

The Contacts activity needs to be improved because:

As the contacts activity can be worked on without much side effects to other parts of the app, it's a good candidate for first migration steps to coroutines and jetpack compose. Lets use:

  • MVVM
  • coroutines
  • compose (--> also removes "flexible Adapter")
  • use code from/ extract Code to nc common lib? (esp. regarding coroutines/compose)

Be aware that adding participants to a Conversation is currently also handled with the Contacts activity.

@mahibi mahibi added enhancement New feature or request 0. Needs triage 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) and removed 0. Needs triage labels Apr 3, 2024
@mahibi mahibi added the feature: 🌐 federation Support for federated conversations label Apr 8, 2024
@jancborchardt
Copy link
Member

It’s best to align with how other native apps on the platform do this. For example, to be on par with Signal, we would have to do 2 changes:

  • If you tap on any person in the list, it will immediately start a 1on1 (or switch to the existing one) instead of going to multiselect.
  • We need to add a very first entry "New group" which then shows the same list but you can multiselect.

This both makes it much quicker to start a 1on1, and much clearer when you are creating a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🌐 federation Support for federated conversations
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

No branches or pull requests

3 participants