-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NcAppSidebar] v-show
doesn't work on sidebar anymore because of Fragment
#5623
Comments
I see. But |
I'm not aware of bugs, it worked fine and used on Talk for a very long time 👀 Moreover, So, I'm changing the structure. |
Or, you mean, that there is an issue with the focus trap on mobile? Then yes, it should not be used. |
open
state to prevent focus trap issues on mobile #5584v-show
cannot be applied on no-root-element componentsv-show
onNcAppSidebar
such as TalkAs it is in general not good to have UI component not representing DOM node in render, I'm adding a new wrapper over sidebar that includes both the sidebar and toggle.
The text was updated successfully, but these errors were encountered: