Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcCounterBubble just keeps counting up #5486

Closed
jancborchardt opened this issue Apr 11, 2024 · 3 comments · Fixed by #5863
Closed

NcCounterBubble just keeps counting up #5486

jancborchardt opened this issue Apr 11, 2024 · 3 comments · Fixed by #5863
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic regression Regression of a previous working feature

Comments

@jancborchardt
Copy link
Contributor

We used to have a limit like 99+ or at least 999+ because after that the unread info just becomes useless. This seems to have been removed, is there any specific reason as to that?

Maybe @nickvergessen as it most prominently happens in Talk (but also would concern Mail, News, and others):

image

@jancborchardt jancborchardt added design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic 0. to triage labels Apr 11, 2024
@nickvergessen
Copy link
Contributor

Was 999+

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature and removed 0. to triage labels Apr 11, 2024
@susnux
Copy link
Contributor

susnux commented Apr 16, 2024

There is no logic in the counterbubble component, it is just a stylistic wrapper. You can put any content inside it, so we can not simply parse it.

Meaning currently it is up to the component user to do something like:

<NcCounterBubble>
    {{ number > 999 ? '999+' : number }}
</NcCounterBubble>

But I think we also have some places where we limit it to 99+.

@jancborchardt
Copy link
Contributor Author

@susnux could we have this logic in the component though, so we can standardize it to 999+?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants