-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NcActionButton] Inconsistent icon position #5284
Comments
@nextcloud-libraries/designers what position is preferred? |
I prefer the second one (vertically centered). That said, IMO, it's not a bug. |
Although I also prefer center aligned when there's only one line of text, I think that the better strategy for this component is to top align given that it accepts multiple lines of text. When there are multiple lines of text, the icon gets further and further away from the title. Here's a real world example of top aligned. @ShGKme note that in your screenshot the icon is not properly centered with the text. |
Yep, confirming what @marcoambrosini said, it's better to have it aligned to the top, with the heading. Otherwise the icon is basically at an arbitrary position. |
#icon
slot is centered andicon-class
is on top.The text was updated successfully, but these errors were encountered: