-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support For Prebaked NODE_OPTIONS defaults? #616
Comments
I think it does make sense! I'd be willing to review a PR. |
related #592 |
This was referenced Jan 3, 2021
I would like to help getting this to work. Should we patch Node and add the passed options as default when building it? Is this the way? |
Any update on the nexe version that enables us to do this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a BUG or a FEATURE REQUEST?:
Feature Request
What happened:
I am evaluating switching from pkg to nexe, given the former is falling significantly behind in support.
One major feature of use that pkg supports is setting default node command line arguments, which it seems isn't possible today in nexe.
In particular, it would be useful to have the ability to toggle features such as
--experimental-modules
,--http-parser
,--tls-min-v1.3
, etc.I do see that setting v8 options is possible during compilation, but it seems that doesn't extend to default node-only options. If I understand properly, it looks like this is accomplished by injecting command line arguments into node_main.cc in pkg here: https://github.com/zeit/pkg-fetch/blob/master/patches/node.v10.15.3.cpp.patch#L535
What you expected to happen:
It seems it would be useful to be able to inject default node command line arguments.
How to reproduce it (as minimally and precisely as possible):
Unsupported feature
Anything else we need to know?:
Nope
Environment
all
12.0.0
12.0.0
3.2.0
2.7.15
Happy to help pitch in if this is deemed a worthwhile feature to support in nexe core. Otherwise, probably can just handle this myself with a custom patch.
The text was updated successfully, but these errors were encountered: