-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase display width #1299 #1483
Conversation
Reference: #1299 Signed-off-by: John M. Horan <[email protected]>
@DennisClark Not sure who needs or wants to review this PR, but I think as discussed during today's jit.si that the changes increase the VCIO display width to that currently used by ScanCode.io. Comments/questions are welcome. |
@johnmhoran Based on the screenshots you posted to me earlier, the changes are fine with me, but I guess someone qualified should review the actual code -- perhaps @TG1999 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmhoran Why not use the entire 100% of the available width?
Width 100% |
---|
Thanks @keshav-space. BTW, did you change the 2 px settings I changed to Re why not? I understood the goal was to imitate the display of ScanCode.io. If the decisionmakers want something different, that's fine -- waiting for instructions.... (Having some white space on left and right looks better to me, fwiw.) |
@johnmhoran @keshav-space the |
Thanks @DennisClark, will do. |
@keshav-space @DennisClark Pushing this shortly: SCIO-like width: 100% width: |
Reference: #1299 Signed-off-by: John M. Horan <[email protected]>
Pushed the 100% update. |
@johnmhoran running your changes locally, I'm not getting the full width. 🤔 |
@keshav-space Thanks. Although I had the full 100% width locally yesterday (thus the screenshot above), atm mine is also narrow, somehow being limited to 865.63px. Looking I don't see where that comes from -- maybe some flex-related CSS setting? Do you have any suggestions? Meanwhile I'll see what I can discover. |
@johnmhoran this is what worked for me locally. .container.max-desktop-width {
width: 100%;
max-width: 100%;
} @media screen and (min-width: 1024px) {
.footer {
width: 100%;
}
} |
@keshav-space Adding the missing |
Reference: #1299 Signed-off-by: John M. Horan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmhoran LGTM!
IMO, the package and vulnerability search should be modified to take up approximately 60-70% of the width, that might look better. We can track this in a separate issue.
Merging! |
Reference: #1299