Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License Category chart to License Info Dashboard #580

Open
mjherzog opened this issue Jun 6, 2023 · 4 comments
Open

Add License Category chart to License Info Dashboard #580

mjherzog opened this issue Jun 6, 2023 · 4 comments
Assignees
Labels

Comments

@mjherzog
Copy link
Member

mjherzog commented Jun 6, 2023

The License Policy pie chart on the License Info Dashboard is a nice idea but perhaps ahead of its time. (And the current link you see with No Data is a dead one)
We should replace the License policy pie chart with one for License Categories.

@OmkarPh
Copy link
Collaborator

OmkarPh commented Jun 8, 2023

We have this category only in top level license references right
image

@AyanSinhaMahapatra
Copy link
Member

@OmkarPh for the link not working: See https://github.com/nexB/scancode-workbench/blob/v4.0-react-typescript/src/pages/LicenseInfoDash/LicenseInfoDash.tsx#L213
noDataLink="https://scancode-toolkit.readthedocs.io/plugins/licence_policy_plugin.html#using-the-plugin" should be
noDataLink="https://scancode-toolkit.readthedocs.io/en/latest/plugins/licence_policy_plugin.html#using-the-plugin" like the other URLs 😉

is a nice idea but perhaps ahead of its time.
Yeah this would be great and should probably be coming after we have nexB/scancode-toolkit#3417 on the toolkit side.

We have this category only in top level license references right
@OmkarPh yes, but these are for each license key, and we need license categories per file here (which each has a license expression), and this needs to be done at the toolkit side first.

@OmkarPh
Copy link
Collaborator

OmkarPh commented Jun 8, 2023

@OmkarPh for the link not working: See https://github.com/nexB/scancode-workbench/blob/v4.0-react-typescript/src/pages/LicenseInfoDash/LicenseInfoDash.tsx#L213 noDataLink="https://scancode-toolkit.readthedocs.io/plugins/licence_policy_plugin.html#using-the-plugin" should be noDataLink="https://scancode-toolkit.readthedocs.io/en/latest/plugins/licence_policy_plugin.html#using-the-plugin" like the other URLs 😉

yep, thanks !

Yeah this would be great and should probably be coming after we have nexB/scancode-toolkit#3417 on the toolkit side.
We have this category only in top level license references right
@OmkarPh yes, but these are for each license key, and we need license categories per file here (which each has a license expression), and this needs to be done at the toolkit side first.

Alright

@OmkarPh
Copy link
Collaborator

OmkarPh commented Sep 4, 2023

We have this category only in top level license references right

@OmkarPh yes, but these are for each license key, and we need license categories per file here (which each has a license expression), and this needs to be done at the toolkit side first.

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants