Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright in LICENSE file not detected (email issue?) #3764

Open
vw-anton opened this issue May 3, 2024 · 1 comment
Open

Copyright in LICENSE file not detected (email issue?) #3764

vw-anton opened this issue May 3, 2024 · 1 comment
Labels

Comments

@vw-anton
Copy link

vw-anton commented May 3, 2024

Description

Copyright in the following file is not detected by ScanCode: https://github.com/videojs/vhs-utils/blob/main/LICENSE

Detected:

{
  "path": "vhs-utils-main/LICENSE",
  "type": "file",
  "name": "LICENSE",
  "status": "application-package",
  "tag": "",
  "extension": "",
  "size": 1078,
  "md5": "b5e2dbf622c44f93baf779123b4c1cc7",
  "sha1": "cb191af7ec58c84aae40b49d4be2646239ab087d",
  "sha256": "83c604241478b9801530198a4dd46fca5fc422015d5a01eeacf96162401ab31a",
  "sha512": "",
  "mime_type": "text/plain",
  "file_type": "ASCII text",
  "programming_language": "",
  "is_binary": false,
  "is_text": true,
  "is_archive": false,
  "is_media": false,
  "is_key_file": true,
  "detected_license_expression": "mit",
  "detected_license_expression_spdx": "MIT",
  "license_detections": [
 ...
  ],
  "license_clues": [],
  "percentage_of_license_text": 96.41,
  "compliance_alert": "",
  "copyrights": [],
  "holders": [],
  "authors": [],
  "package_data": [],
  "for_packages": [
    "pkg:npm/%40videojs/[email protected]?uuid=7803ef84-762b-4555-b5cf-0935ad59f1f5"
  ],
  "emails": [
    {
      "email": "[email protected]",
      "end_line": 1,
      "start_line": 1
    }
  ],
  "urls": [],
  "extra_data": {}
}

Expected:
brandonocasey <[email protected]> or at least brandonocasey is returned as copyright

How To Reproduce

scnacode.io config below

System configuration

  "tool_name": "scanpipe",
  "tool_version": "34.2.0",
  "other_tools": [
    "pkg:pypi/[email protected]"
@vw-anton vw-anton added the bug label May 3, 2024
pombredanne added a commit that referenced this issue May 6, 2024
Reference: #3764
Reported-by: Anton Augsburg @vw-anton
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member

@vw-anton Thanks for the report!
See the fix in ab6699f ... the issue was not about the email, but rather about the lack of year in this copyright form using a (somewhat uncommon) all lower case made up name.

pombredanne added a commit that referenced this issue May 9, 2024
Make detection of copyright with a single lowercase name more specific

Reference: #3764
Reported-by: Anton Augsburg @vw-anton
Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants