Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requalify license rule #3762

Open
pombredanne opened this issue May 2, 2024 · 2 comments
Open

Requalify license rule #3762

pombredanne opened this issue May 2, 2024 · 2 comments
Assignees
Labels
license-review A license detection issue that needs review

Comments

@pombredanne
Copy link
Member

https://github.com/nexB/scancode-toolkit/blob/04e24e0c7edccaa27ad2cf495e15abb849a922c9/src/licensedcode/data/rules/boost-original_3.RULE is not really the same as boost-original as this is does not have the requirements to include the license in all copies as in the
https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/boost-original.LICENSE

@pombredanne pombredanne added the license-review A license detection issue that needs review label May 2, 2024
@DennisClark
Copy link
Member

See https://scancode-licensedb.aboutcode.org/boost-original.html
which has text that is an exact match to the boost-original_3.RULE -- no additional requirements

See https://scancode-licensedb.aboutcode.org/boost-1.0.html
which does contain the requirements to include the license in all copies -- a different and newer license altogether

See https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/boost-original.LICENSE
which appears to have the same text as boost-original.html and boost-original_3.RULE

So I don't think there is a problem at all. Closing.

@DennisClark
Copy link
Member

on the other hand, this rule
https://github.com/nexB/scancode-toolkit/blob/04e24e0c7edccaa27ad2cf495e15abb849a922c9/src/licensedcode/data/rules/boost-1.0_9.RULE
should be improved to require the entire text for a match on boost-1.0

@AyanSinhaMahapatra or @pombredanne please take a look and improve as you see fit, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
license-review A license detection issue that needs review
Projects
None yet
Development

No branches or pull requests

3 participants