Invalid copyright not detected #3659
Labels
Comments
|
I'm taking this one @pombredanne |
|
@pombredanne If I'm right, I've just to make changes as you suggest or this require anything else, if anything else required you can tell me I'm beginner and want to make good contributions. |
|
@CaptainTron You could start by crafting the unit tests that fail for now scancode-toolkit/src/cluecode/copyrights.py Line 3987 in 79aae34 |
@pombredanne can you elaborate a bit more, I'm not getting as of now, as what unit test to look for, I've gone through that line and doc, still I'm confused!. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[C] The Regents of the University of Michigan and Merit Network, Inc. 1992, 1993, 1994, 1995 All Rights Reservedis rare and not detected because[C]is not a valid copyright "sign"We have a few other cases in https://github.com/search?q="Copyright+[C]"&type=code
The only sane resolution I can think of is to normalize these warts in text preparation:
[C] The Regents of the Universityby(C) The Regents of the UniversityCopyright [c]byCopyright (c)in all character cases.[C]cannot be/is not a valid sign and this would otherwise trigger a badzillion of false positives as seen in https://github.com/search?q="[C]"&type=code (actually only millions, not badzillions)The text was updated successfully, but these errors were encountered: