Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some effort to compile on windows #7
base: master
Are you sure you want to change the base?
Some effort to compile on windows #7
Changes from 1 commit
86f8edd
034fb2a
66cd733
781bd43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHARED_LIB_EXT
is only used here. How about hard-coding it todll
here and removing the variable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at this again, I wonder how it even compiles. Here, we're passing
wchar_t*
intostfl_ipool_create()
which expectschar*
— why isn't it a compilation error to do so?Assuming
wchar_t*
simply gets casted tochar*
somehow, this code is broken:wchar_t
for a digit would contain zeroes (digits are part of ASCII, many encodings are extensions of ASCII, including all of Unicode encodings). Thusstfl_ipool_create()
will only use the first digit of the codepage, if even that (zeroes might be at the very start of the string).Here's a test program to verify that a string can be converted from UTF-8 to WCHAR_T and then to UTF-32:
Can you please modify it to run on Windows? In the process you'll figure out all the kinks of how to initialize iconv, and then you can just copy that code here.