-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Kubernetes example for custom node modules #17848
Conversation
keegoid-nr
commented
Jun 29, 2024
- add EFS + EKS example detailing how to copy custom modules to a PV prior to launching the SJM
- fix yaml parameter names
add EFS + EKS example detailing how to copy custom modules to a PV prior to launching the SJM
Hi @keegoid-nr 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@bpeckNR - I'd love a review of this draft. |
@jeff-colucci We are ready to merge this PR. |
Fixing numbering and indents
``` | ||
|
||
### Create `mount-custom-mods-pod` to copy your custom-modules directory | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a step 1 or some sort of direction here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeff-colucci. It could be like:
Custom-modules directory
- Create
mount-custom-mods-pod
to copy your custom-modules directory
@keegoid-nr There's some funky-ness going on with the numbering not working correctly, I believe I've fixed it and I will keep an eye on it when it builds. In the meantime, there seems to be a missing step 1 text, which I highlighted above. Once that is fixed and the indentation issues in the MDX file are confirmed to be working, we can push this out! |
@jeff-colucci Looks like this part got messed up a bit. It should be a code block. |
@jeff-colucci The example should be indented so the numbered items can go from 1 to 2 intead of 1 to 1. |
@jeff-colucci I'll create a new PR with these fixes. |