Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #559

Open
PhilipVinc opened this issue Mar 16, 2021 · 1 comment
Open

Roadmap #559

PhilipVinc opened this issue Mar 16, 2021 · 1 comment

Comments

@PhilipVinc
Copy link
Member

PhilipVinc commented Mar 16, 2021

I would like to keep here a list of issues and enhancements to consider for the future

New Features:

Models:

Hilbert:

Samplers:

Variational States:

  • Make padding optional, give a way to control it.
  • In general, find a way to work with operators where padding is not an on/off switch, but rather works in increments of an arbitrary quantity (say 512)...
  • Consider jitting model construction jit model init #832 (Done)

Tests:

  • Add benchmarks to avoid performance regressions Benchmarks? #68
  • Eventually consider benchmarking also jit-compile time?
  • Properly test Liouvillian gradient (done)

Misc

  • Possibly improve jit time of nk.sampler.sample by refactoring the code and where we jit
  • Keep an eye out for serialising jax jitted functions: Jax#476
  • ~Upstream what we need for complex number support to Flax and eventually remove nk.nn ~ (Done)
  • Some utils to deserialise our .log files and reconvert to our history objects and make plotting easier might be nice.
    • Partly done for deserialising, not for plotting.

Issues:

  • MCState.samples before and after serialization/deserialization don't match. Right now, when serialising a variational state, we store the parameters and the sampler_state. However, if we have already sampled the state, the current sampler_state will generate the next batch of samples. So we should keep around the last sampler_state and serialise that one, so that when calling .samples after deserialisation we get the same samples. (Done)

Docs:

  • Docs have plenty of build warnings. Those should be addressed (Done)
  • Add Developer documentation
  • Move the core of the docs (not the website) to ReadTheDocs for automatic versioning? (Done)
@gcarleo
Copy link
Member

gcarleo commented Mar 16, 2021

Yes, I would add

@PhilipVinc PhilipVinc pinned this issue May 27, 2021
@femtobit femtobit unpinned this issue May 27, 2021
@femtobit femtobit pinned this issue May 27, 2021
@jwnys jwnys unpinned this issue Jul 29, 2022
@PhilipVinc PhilipVinc pinned this issue Oct 23, 2022
@jwnys jwnys unpinned this issue Mar 3, 2023
@PhilipVinc PhilipVinc pinned this issue Aug 18, 2023
@inailuig inailuig unpinned this issue Nov 10, 2023
@inailuig inailuig pinned this issue Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants