Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform kernels and convolutions using a transformer before code generation #1050

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented May 9, 2024

For a full discussion, see #1020.

Removes the "inline aliases convolution" concept. Convolutions or inlines can no longer be assigned to. For those cases, the onEvent handler blocks and an explicitly specified set of state variables need to be used.

TODO

  • Fix issue with the units: need a full table of predefind units and multiplers for sympy parsing.
  • Fix issue with the units: ODEs coming back from ODE-toolbox have mixed units/no units, such as x/tau**2 - x. Overall physical unit of the ODE rhs should be 1/s.
    • disable the check! Already in place via after_ast_rewrite in co_cos_manager.py.
  • Pick an extreme lowest priority for the added event handlers and add the handlers with the right priority
  • Fix CI
  • Fix NEST-compartmental
  • Update documentation

Fixes #1020.
Fixes #1013.
Fixes #993.
Fixes #1008.

@clinssen clinssen force-pushed the kernel-transformer branch 2 times, most recently from 3a175ae to 64d09f6 Compare September 1, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant