Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lua_ls): return longest root path #3515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(lua_ls): return longest root path #3515

wants to merge 1 commit into from
+5 −6

Conversation

mangkoran
Copy link

This commit doesn't address the case when root path == vim.env.HOME as the case lack return when it's true (#2110)

Fix #3508

@mangkoran
fix(lua_ls): return longest root path
765e664 
This commit doesn't address the case when root path == vim.env.HOME as
the case lack return when it's true (neovim#2110)

Fix neovim#3508
@mangkoran mangkoran requested a review from glepnir as a code owner December 15, 2024 10:48
@mangkoran
Copy link
Author

mangkoran commented Dec 17, 2024 •
edited
Loading

Hi @justinmk is there any other thing that need to be addressed for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glepnir glepnir glepnir approved these changes

@pitkling pitkling pitkling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mangkoran @pitkling @glepnir