Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: styles for hover state for sponsors logo can be improved #295

Closed
Roshanjossey opened this issue Oct 2, 2022 · 3 comments
Closed

Comments

@Roshanjossey
Copy link

Problem

hover effect on Sponsors logo
neovim-sponsor

Reason

anchor tag has display: inline style as default.

Solution

add style display: block

neovim-sponsor-block

We could also discuss if this is the right hover effect for images. It works well for text links but for images, we could go another way.

@justinmk
Copy link
Member

justinmk commented Oct 2, 2022

Thanks for figuring out the issue here, it was bugging me :)

I'm also open to thinking about an improved border style or color for normal text links, for both light/dark mode--we need perhaps a different, or additional/complementary border style for special things in the user docs: https://neovim.io/doc/user2

@Roshanjossey
Copy link
Author

I did some reading around accessibility of links and using image as link content and came across this a11yproject/a11yproject.com#1344. So, I think it's a good idea to change alt text to explicitly state that it's a link.

For styling image links, doing a brightness filter could a good effect.

additional/complementary border style for special things in the user docs: neovim.io/doc/user2

I didn't understand what special things in that page was. Could you please elaborate?

@justinmk
Copy link
Member

justinmk commented Oct 3, 2022

additional/complementary border style for special things in the user docs: neovim.io/doc/user2

I didn't understand what special things in that page was. Could you please elaborate?

Things like <code>, <pre> and special highlights for strings like CTRL-x, TODO and other symbols found in :help. See #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants