Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: React warnings regarding unrecognized properties rendered to the DOM #3894

Open
markusguenther opened this issue Dec 10, 2024 · 0 comments
Open

TASK: React warnings regarding unrecognized properties rendered to the DOM #3894

markusguenther opened this issue Dec 10, 2024 · 0 comments
Labels
8.3 CKEditor

Comments

@markusguenther
Copy link
Member

Description

When interacting with the CKEditor component, specifically clicking on the editor and attempting to type, the following React warnings are triggered:

Warning: React does not recognize the executeCommand prop on a DOM element.
Warning: React does not recognize the formattingUnderCursor prop on a DOM element.

Root Cause

These warnings occur because the executeCommand and formattingUnderCursor props are passed directly to DOM elements within the CKEditor component. React does not recognize these as valid DOM attributes, leading to unnecessary warnings in the console.

Steps to Reproduce

  1. Take care that editorOptions: formatting:code is true (for instance, test with Neos.Demo)
  2. Open a page and create a text content node
  3. Click inside an inline editable

Expected behavior

No, react errors in the console.

Actual behavior

Screenshot 2024-12-10 at 15 07 39

Affected Versions

Neos: 8.3

UI: 8.3
markusguenther added a commit to markusguenther/neos-ui that referenced this issue Dec 10, 2024
@markusguenther
BUGFIX: Prevent warnings for unrecognized DOM props
6b63d53 
This change addresses React warnings related to invalid DOM attributes:
- Removed `executeCommand` and `formattingUnderCursor` from being passed to DOM elements.
- Ensured these props are only handled within components where they are relevant, preventing them from being incorrectly rendered on DOM elements.

These update prevent unnecessary warnings in the console.

Resolves: neos#3894
@markusguenther markusguenther mentioned this issue Dec 10, 2024
Open
@markusguenther markusguenther changed the title React warnings regarding unrecognized properties rendered to the DOM TASK: React warnings regarding unrecognized properties rendered to the DOM Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.3 CKEditor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markusguenther