[1.21.x] Preserve original iteration order in Attribute Formatting API #1831
+13
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the attribute formatting API to maintain the original (component-provided) attribute iteration order, instead of relying on a predefined sort order. The old sort order was developed in 1.20, before vanilla stored the attribute modifiers as a
List
(it was previously aMultimap
).It also updates the debug text for base modifiers to be less verbose. The current form of the text
[Entity: %s | Base: %s]
is simply too long and not necessary when the user already understands what the debug information being presented means (which is to be assumed for debug data like this).Screenshots of the change to the base modifier debug text:
Before:
After: