Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage all and commit automatically. #128

Open
Nageswari-droid opened this issue Jan 2, 2021 · 3 comments
Open

Stage all and commit automatically. #128

Nageswari-droid opened this issue Jan 2, 2021 · 3 comments
Assignees
Labels
Feature request Features which are requested by users or collaborators front-end up for grabs

Comments

@Nageswari-droid
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
If the client click on commit changes before staging operation then all the files will be staged automatically.

Describe alternatives you've considered
Not applicable

Additional context
None

@Nageswari-droid Nageswari-droid added the Feature request Features which are requested by users or collaborators label Jan 2, 2021
@neel1996
Copy link
Owner

Suggestion

This feature does not require a separate API to carry out the operation. From the UI, the component for committing the changes can be redesigned to call the "stage all" api and on successful response, the "commit changes" api can be invoked with a proper commit message.

@neel1996 neel1996 changed the title Stage and commit automatically. Stage all and commit automatically. Jan 30, 2021
@Nageswari-droid
Copy link
Collaborator Author

How can I proceed?

If a user clicks on "Commit changes" button before staging, instead of displaying "No Staged files to commit" it should list all the untracked/modified/deleted files with a proceed button like "Stage all and commit". Am I right about it or how you are expecting?

@neel1996
Copy link
Owner

@Nageswari-droid Currently, when "Commit changes" is clicked, it will not let the user do it when there are no staged files available. As part of this feature, that condition needs to be changed to check for all the worktree changes and let the user "Stage all the changes and commit it" in a single click

The gitChanges query returns the worktree changes from the target repo.

gitChanges(repoId: String!) {
    gitUntrackedFiles: [String]!
    gitChangedFiles: [String]!
}

If the arrays are empty then appropriate warning should be thrown, or else the commit should be allowed after staging all the changes.

@Nageswari-droid Nageswari-droid self-assigned this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Features which are requested by users or collaborators front-end up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants