Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSuccess callback being called regardless of result #51

Open
KaduCmK opened this issue Oct 21, 2023 · 1 comment
Open

onSuccess callback being called regardless of result #51

KaduCmK opened this issue Oct 21, 2023 · 1 comment

Comments

@KaduCmK
Copy link

KaduCmK commented Oct 21, 2023

Tried testing the library using mailtrap, everything works great but if if try to simulate an error (in my case, putting a wrong smtp username), the onSuccess callback is called, followed by the onFailure with the error code. I don't think that's right...

to reproduce just set up a basic handler, define both callbacks and send an email through mailtrap but with a wrong username

@nedimf
Copy link
Owner

nedimf commented Dec 6, 2023

Sadly, I haven't had time to check this out, but yeah I agree it is not wanted behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants