Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runes have wrong Skyblock ID in inventory #25

Open
Olivki opened this issue Feb 17, 2024 · 2 comments
Open

Runes have wrong Skyblock ID in inventory #25

Olivki opened this issue Feb 17, 2024 · 2 comments

Comments

@Olivki
Copy link

Olivki commented Feb 17, 2024

In an attempt to port Hypixel Plus to the Firmament texture pack format I encountered an issue when porting the rune textures.

Given a model file named redstone_rune__1 in /firmskyblock/models/, as per the ID given when using Copy Texture Pack Id keybind from the Power Users settings, the replaced texture will correctly show up in the REI menu:

javaw_2024-02-17_02-15-48

But in the inventory or any storage unit it will still show up as the head model:

javaw_2024-02-17_02-16-51

The issue seems to be that the rune, while in an inventory, has the id of just RUNE:

javaw_2024-02-17_02-17-47

@nea89o
Copy link
Owner

nea89o commented Feb 17, 2024

Oh, interesting. Runes by default don't have a hypixel id other than just RUNE so i add the other metadata myself and i apparently i forgot to do that in some spots. Below is a list of item types that are missing right now, but theyll be added in the next update.

            // TODO: RUNE, ENCHANTED_BOOK, PARTY_HAT_CRAB{,_ANIMATED}, ABICASE

@nea89o
Copy link
Owner

nea89o commented Feb 17, 2024

image
Fixed it for runes, enchant books and abicases. I don't have a party hat right now, but i'll look into fixing those in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants