Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'afterClose' event is fired right after 'opened' event #229

Open
MaKCbIMKo opened this issue Sep 7, 2021 · 0 comments
Open

'afterClose' event is fired right after 'opened' event #229

MaKCbIMKo opened this issue Sep 7, 2021 · 0 comments

Comments

@MaKCbIMKo
Copy link

I faced issue with afterClose event.

Yes, I saw this PR (#220) and your comment said that you're aware. At that time PR got merged.

Later, I assume this commit (340cc7f) should fix this issue.

But it's not. I still can see this issue here - https://ncstate-sat.github.io/popover/

Interesting thing: it seems like first cycle (open and close) it works fine, but starting with second open and later - it fires afterClose event right after opened.

For some cases that might be fine. But for me, since I have logic that that should 'start before it's open' (aka opened event) and 'end after it's closed' (aka afterClose). And this 'but' ruins the event flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant