You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A project i'm working on, using node-geocoder to access "adresse.data.gouv.fr" and Open Street Map's geocoding services, requires to get the scoring/confidence field returned by these services.
I modified the '_geocode' function for these providers to return add this value to the formated result, and updated the tests to take this into account. 'npm test' and 'npm run lint' are happy.
I'm wondering, before initiating a pull request :
does this kind of modification suits you ?
if not, should I :
implement it another way (as extras, in the '_formatResult' function used by both '_geocode' and '_reverse') ?
keep it in a fork without merging it in this repository ?
Have a nice day.
The text was updated successfully, but these errors were encountered:
The goal of this library is to provide a standardized abstraction for a lot of geocoder APIs.
I am not sure the score is something that could be generic for all providers.
It could maybe be implemented as an extra property.
I agree, this score property isn't generic at all.
I will move it as an extra in my fork, and when everything is good I will try a pull request.
Thank you.
Hello,
A project i'm working on, using node-geocoder to access "adresse.data.gouv.fr" and Open Street Map's geocoding services, requires to get the scoring/confidence field returned by these services.
I modified the '_geocode' function for these providers to return add this value to the formated result, and updated the tests to take this into account. 'npm test' and 'npm run lint' are happy.
I'm wondering, before initiating a pull request :
Have a nice day.
The text was updated successfully, but these errors were encountered: