Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulas for ride_results producing negative values #6

Closed
navirobayo opened this issue Jul 21, 2023 · 2 comments
Closed

Formulas for ride_results producing negative values #6

navirobayo opened this issue Jul 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@navirobayo
Copy link
Owner

Issue: The ResultsScreen is intended to display the results of the ride analysis however the result variables are displaying negative values, which is unexpected.

The problematic formulas can be found at venom\lib\src\presentation\ride\bloc\ride_result.dart

To Do: The result variables should only display positive integer values.

@navirobayo navirobayo added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 21, 2023
@navirobayo navirobayo pinned this issue Jul 21, 2023
@navirobayo
Copy link
Owner Author

The problem is related to how the information is being used in the new architecture. This happened to me when I was building the prototype.

I suggest to keep the original approach to avoid this issue: Pass the information from screen to screen, not as a static value that can be accessed later on, in this way the user can return to a screen, change a value and that won't affect the results of the calculation.

This approach helps also to print each of the variables in future debugging, allows the app to work with real time data, and resolves the new bug (Time selector does not start when the user goes back)

What do you think? @hamidjalili59

@navirobayo navirobayo removed help wanted Extra attention is needed good first issue Good for newcomers labels Jul 23, 2023
@navirobayo
Copy link
Owner Author

Resolved in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant