Disable Time Port calls when TlmPacketizer
is being used
#3039
Replies: 2 comments 1 reply
-
@bocchino and I talked about options:
|
Beta Was this translation helpful? Give feedback.
-
I would push back against this change. F´ is designed such that the behavior of a component is independent of what it connects to. This change would break that property. Solution 1 could easily break packet logging. A typical pattern is to fork telemetry into a log and into the downlink with packetizer. This solution will invalidate logging at this level. Solution 2 will break projects that need telemetry time stamps as close to the source of truth as possible. We put in a component time override for this very purpose. Moving that time to some other component would hard-break the ability for projects to use the channel time as a source of true time. The only solution I see would be to have a global build switch of the form "DISABLE_COMPONENT_TIME" and have that determine if the autocoding puts in
This change would require a lot of architectural changes to support a modest optimization. Is there something driving this request or some known area where this overhead is insufficient? |
Beta Was this translation helpful? Give feedback.
-
The FPP autocoder generates
Fw.Time
calls for components that contain telemetry channels. Then theFw.Tlm
output port is called with the value and the time tag.Svc/TlmChan
puts the telemetry, including the time tag, in a packet and sends it to the ground. The ground software uses the time tag to display the measurement time.Svc/TlmPacketizer
discards the time tag, and puts the telemetry into the destination packet at the specified offset. On each scheduler call,Svc/TlmPacketizer
checks each packet to see if there are new updates to any of the channels. If there are, the packet will get a packet-level timestamp.So, in essence, when
Svc/TlmPacketizer
is used, all the component time port calls are useless. It would be nice to have a global way to turn off the component time calls so all those CPU cycles are not wasted.Beta Was this translation helpful? Give feedback.
All reactions