FramingProtocol Use of U8 vs char

[VR314]

In the validate function of the FprimeProtocol.cpp file, the variables byte, calc, and sent of type char when ring.peek is defined to return a U8 and so does the hashBuffer. Why was this done and is there a possibility for issues coming up because of the signedness of the values?

[LeStarch]

There should not be issues because of the change in sign here, as the hash function can accept any data (void*) and convert it to what it needs.

This is likely a coding bug using imprecise types. I will convert this to a code-cleanup issue! Thanks for noting it!