Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

336 revisit crypto configh defines #352

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

336 revisit crypto configh defines #352

wants to merge 3 commits into from

Conversation

Donnie-Ice
Copy link
Contributor

No description provided.

@Donnie-Ice Donnie-Ice self-assigned this Nov 15, 2024
@Donnie-Ice Donnie-Ice linked an issue Nov 15, 2024 that may be closed by this pull request
Revisit crypto_config.h defines #336
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (a3f2e78) to head (234d64f).
Report is 29 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_key_mgmt.c 81.81% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #352      +/-   ##
==========================================
- Coverage   84.04%   83.09%   -0.96%     
==========================================
  Files          83       81       -2     
  Lines       23507    20399    -3108     
  Branches     1783     1705      -78     
==========================================
- Hits        19757    16950    -2807     
+ Misses       3075     2772     -303     
- Partials      675      677       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jlucas9
jlucas9 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that BYTE_LEN never changes. Was that a linter request to define?

@Donnie-Ice
Copy link
Contributor Author

Yes, the linter lit up every single number, except for cases like +1 or -1. I don't actually recall if the shifts were lit up, but the var * 8 and var / 8 definitely were.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucas9 jlucas9 jlucas9 approved these changes

@rjbrown2 rjbrown2 Awaiting requested review from rjbrown2

@dccutrig dccutrig Awaiting requested review from dccutrig

Assignees

@Donnie-Ice Donnie-Ice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit crypto_config.h defines
3 participants
@Donnie-Ice @codecov-commenter @jlucas9