Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the ring crate to the latest version #89

Open
yurivict opened this issue Jan 13, 2024 · 3 comments
Open

Please update the ring crate to the latest version #89

yurivict opened this issue Jan 13, 2024 · 3 comments
Assignees
Labels
A-agent Area: client A-client Area: client C-duplicate Category: This issue or pull request already exists E-easy Effort: easy. A task that would be a great starting point for a new contributor. S-external Status: awaiting some external actions

Comments

@yurivict
Copy link

yurivict commented Jan 13, 2024

Describe the bug

It fixes failures like this.

@SajjadPourali
Copy link
Contributor

SajjadPourali commented Jan 13, 2024

@yurivict : Thank you for the report. Narrowlink relies on Quinn for the P2P communications over QUIC, which still uses Ring 0.16 and it is out of my control at this time. Fortunately, it appears that Quinn is going to have a new release very soon, which will fix the issue (see: quinn-rs/quinn#1737). I'll address it in narrowlink as soon as Quinn releases the new version.

@SajjadPourali SajjadPourali added C-duplicate Category: This issue or pull request already exists E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-client Area: client A-agent Area: client S-external Status: awaiting some external actions labels Jan 13, 2024
@senpro-ingwersenk
Copy link

The mentioned PR has been completed and closed, by the way. :)

@SajjadPourali
Copy link
Contributor

The mentioned PR has been completed and closed, by the way. :)

Updating the ring involves some breaking changes, which makes it a bit time-consuming. Moreover, I am refactoring Narrowlink to add support for vertical scaling and make it easier to use. Currently, Narrowlink is somewhat challenging to configure for some users and is also very difficult to scale up. Thus, I decided to use the new version of the ring in the refactored code. I’ll prioritize finishing the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-agent Area: client A-client Area: client C-duplicate Category: This issue or pull request already exists E-easy Effort: easy. A task that would be a great starting point for a new contributor. S-external Status: awaiting some external actions
Projects
None yet
Development

No branches or pull requests

3 participants