Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno-lint: ignore directives do not work #630

Open
zachauten opened this issue Apr 20, 2022 · 1 comment · May be fixed by #642
Open

deno-lint: ignore directives do not work #630

zachauten opened this issue Apr 20, 2022 · 1 comment · May be fixed by #642

Comments

@zachauten
Copy link

zachauten commented Apr 20, 2022

According to the docs, a // deno-lint-ignore directive should ignore a failing rule on the next line. The following is an example I ran where this fails:

~$ cat main.js
// deno-lint-ignore require-await
async function main() {
	console.log('hello world!');
}

main();
~$ npx denolint
error[require-await]: Async function 'main' has no 'await' expression.
 --> ~/main.js:2:1
  |
2 | / async function main() {
3 | | 	console.log('hello world!');
4 | | }
  | |_^
  |
  = help: Remove 'async' keyword from the function or use 'await' expression inside.
@prantlf
Copy link
Contributor

prantlf commented Aug 1, 2022

You can use eslint ignore directives as a workaround:

  ...
  // eslint-disable-next-line no-empty
} catch {}

UPDATE: Just the eslint-disable-next-line.

@prantlf prantlf linked a pull request Sep 24, 2022 that will close this issue
prantlf added a commit to prantlf/denolint that referenced this issue Sep 28, 2022
This is the first version released after forking the [customisation] of the [original project].

* Scan specific directories ([631], [647])
* Scan directories configured by `files.include` ([635], [645])
* Fix handling of the configuration `files.exclude` ([635], [646])
* Support disabling rules in souces using `eslint-disable` ([630], [642])
* Support including and excluding rules in the `lint` method ([631], [643])
* Execute the command-line tool `denolint` without loading the Node.js VM ([648])
* Allow specifying directories, files and patterns as input for checking

[customisation]: https://github.com/prantlf/node-rs/commits/combined
[original project]: https://github.com/napi-rs/node-rs/tree/main/packages/deno-lint
[630]: napi-rs/node-rs#630
[631]: napi-rs/node-rs#631
[635]: napi-rs/node-rs#635
[642]: napi-rs/node-rs#642
[643]: napi-rs/node-rs#643
[645]: napi-rs/node-rs#645
[646]: napi-rs/node-rs#646
[647]: napi-rs/node-rs#647
[648]: napi-rs/node-rs#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants