Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpect Nul Error of CString while creating javascript object #2110

Open
hyf0 opened this issue May 13, 2024 · 1 comment
Open

Unexpect Nul Error of CString while creating javascript object #2110

hyf0 opened this issue May 13, 2024 · 1 comment

Comments

@hyf0
Copy link
Contributor

hyf0 commented May 13, 2024

Related:

Rollup use '\0' as the virtual module convention, which some modules might have names like "\0some-virtual-modules". Rolldown follows the behavior, but there's a error occrured in such code: https://github.com/rolldown/rolldown/blob/49d4b5c03ab699d71125782c746d15b9b276821c/crates/rolldown/src/utils/chunk/render_chunk.rs#L76-L78

I guess this is due to NAPI-RS use CString on places doesn't require to be valid CString.

@hyf0
Copy link
Contributor Author

hyf0 commented May 13, 2024

Might be related

let key = CString::new(name)?;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant