Add windows gnu target #2026
Open
Add windows gnu target #2026
+152
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
|
and the dependencies might have to be updated as well, because this is self hosting |
|
Ah, I see the failing tests, Ill work on that |
Kreijstal
force-pushed
the
msys2mingw
branch
7 times, most recently
from
65b5336
to
eede4d6
Compare
|
I understand, msvc is not a configuration but target_env="msvc" is. To test this under windows-gnu you need the gnu version of node, tell me if this is required |
|
@Kreijstal can you add a Windows gnu CI to test the platform? |
this adds clang64 compiler to the test suite
Open
I added test that tell you that it compiles at least with rust, in the msys2 platform however the tests will fail since they can't install rollup, for the reason that this pull request is precisely trying to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
I am not well acquainted with this project or rust or node api, but there has been this bug that has been bugging me for a while, when using napi-rs, I put msvc target on its own category, since it is different from clang or gcc, and added static linking for windows, I added a build.rs script for napi, so that you can
cargo teston the repository. Additionally I added dynamical symbol loading for gnu targets as well, so you can either choose to static or dynamic load, since I do not have msvc, I can not test how this works for msvc, but since I did not change its path, it should work as it has worked before. I noticed some people have the same issue and someone even came with a patch!/Workaround!Fixes #2001
Fixes #1893
related #1480 (comment) (patch came from this thread)
Please review