Add option to specify host name (host and -h or --host respectively)
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gorankarlic can we use |
napcs
reviewed
Feb 7, 2023
|
Can we merge this? |
napcs
requested changes
Apr 8, 2024
| @@ -58,7 +58,8 @@ $ livereload ~/website | |||
|
|
|||
| The commandline options are | |||
|
|
|||
| * `-p` or `--port` to specify the listening port | |||
| * `-p` or `--port` to specify the listening port. | |||
| * `-h` or `--host` to specify the host name to which to bind the server. | |||
There was a problem hiding this comment.
@gorankarlic looks like this should change too.
Suggested change
| * `-h` or `--host` to specify the host name to which to bind the server. | |
| * `-b` or `--bind` to specify the host name to which to bind the server. |
| @@ -146,6 +147,7 @@ The first are some configuration options, passed as a JavaScript object: | |||
|
|
|||
| * `https` is an optional object of options to be passed to [https.createServer](http://nodejs.org/api/https.html#https_https_createserver_options_requestlistener) (if not provided, `http.createServer` is used instead) | |||
| * `port` is the listening port. It defaults to `35729` which is what the LiveReload extensions use currently. | |||
| * `host` is the host name to which to bind the server. It defaults to `localhost`. | |||
There was a problem hiding this comment.
Suggested change
| * `host` is the host name to which to bind the server. It defaults to `localhost`. | |
| * `bind` is the host name to which to bind the server. It defaults to `localhost`. |
| @@ -230,6 +232,10 @@ When submitting code, please keep commits small, and do not modify the README fi | |||
|
|
|||
| # Changelog | |||
|
|
|||
| ### 0.9.4 | |||
| * Server: Added `host` option to specify the host name to bind the server to. | |||
| * CLI: Added `-h` or `--host` option to specify the host name to bind the server to. | |||
There was a problem hiding this comment.
Suggested change
| * CLI: Added `-h` or `--host` option to specify the host name to bind the server to. | |
| * CLI: Added `-b` or `--bind` option to specify the host name to bind the server to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to specify host name (
hostand-hor--hostrespectively). Resolves #161.